Re: [PATCH 14/19] RISC-V: error handling for subset parsing

Project / Subsystem

binutils / risc-v

Date

2026-04-29

Proposer

Jiawei <jiawei@iscas.ac.cn>

Source type

public_inbox

Consensus

Ready to Land

Sentiment

/10

Technical tradeoffs

  • Increased code complexity due to the temporary subset approach.
  • Potential performance overhead due to copying the subset list, though likely negligible.

All attributes

project
binutils
subsystem
risc-v
patch_id
discussion_id
36f9cb9f-0dc3-470e-b42d-da0c45694108@iscas.ac.cn
source_type
public_inbox
title
Re: [PATCH 14/19] RISC-V: error handling for subset parsing
headline
RISC-V: Error handling for subset parsing
tldr
When parsing RISC-V architecture subsets, keep the previous ISA state upon parsing failures, instead of partially updating the subset list.
proposer
Jiawei <jiawei@iscas.ac.cn>
consensus
Ready to Land
outcome
ready
sentiment_score
technical_tradeoffs
  • Increased code complexity due to the temporary subset approach.
  • Potential performance overhead due to copying the subset list, though likely negligible.
series_id
binutils:risc-v: error handling for subset parsing
series_role
reply
series_parts
[]
tags
  • risc-v
  • error handling
  • architecture parsing
bugzilla_url
date
2026-04-29T00:00:00.000Z

Re: [PATCH 14/19] RISC-V: error handling for subset parsing

This patch improves error handling when parsing RISC-V architecture subsets (-march and .option arch). If parsing fails, the previous ISA state is kept, preventing partially updated subset lists. The change ensures that conflicting extensions are not unexpectedly enabled due to parsing errors.