Re: [PATCH 5/8] bfd/s390+sh: don't abuse BFD_RELOC_32_GOT_PCREL
Project / Subsystem
binutils / bfd/s390+sh
Date
2026-04-30
Proposer
Alexandre Oliva <oliva@gnu.org>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Corrects existing mis-use of relocation enumerators.
All attributes
- project
- binutils
- subsystem
- bfd/s390+sh
- patch_id
- —
- discussion_id
- orlde5hy5u.fsf@lxoliva.fsfla.org
- source_type
- public_inbox
- title
- Re: [PATCH 5/8] bfd/s390+sh: don't abuse BFD_RELOC_32_GOT_PCREL
- headline
- Bfd/s390+sh: Don't abuse BFD_RELOC_32_GOT_PCREL
- tldr
- Fixes incorrect usage of a PC-relative relocation enumerator for non-PC-relative relocations in the s390 and SH backends of the Binary File Descriptor (BFD) li…
- proposer
- Alexandre Oliva <oliva@gnu.org>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Corrects existing mis-use of relocation enumerators.
- series_id
- binutils:bfd/s390+sh: don't abuse bfd_reloc_32_got_pcrel
- series_role
- reply
- series_parts
- []
- tags
-
- • bfd
- • relocation
- • s390
- • sh
- • code quality
- bugzilla_url
- —
- date
- 2026-04-30T00:00:00.000Z
Re: [PATCH 5/8] bfd/s390+sh: don't abuse BFD_RELOC_32_GOT_PCREL
This patch corrects the usage of BFD_RELOC_32_GOT_PCREL in the s390 and SH backends of the BFD library. The enumerator was being incorrectly used for R_390_GOT32 and R_SH_GOT32 relocations, which are not PC-relative. Correcting this usage helps to properly use the enumerator and avoids potential issues in the future.