Re: [PATCH 4/4] ld: Fix discarded-qualifiers problems in ldelf.c

Project / Subsystem

binutils / ld

Date

2026-05-03

Proposer

Calvin Owens <calvin@wbinvd.org>

Source type

public_inbox

Consensus

Ready to Land

Sentiment

/10

Technical tradeoffs

  • The patches address compiler warnings, leading to cleaner code.
  • The fixes prevent potential unintended modification of constant data.
  • The impact is relatively small, as the code likely functioned correctly even with the warnings.

All attributes

project
binutils
subsystem
ld
patch_id
discussion_id
afeogEt856N67LEG@mozart.vkv.me
source_type
public_inbox
title
Re: [PATCH 4/4] ld: Fix discarded-qualifiers problems in ldelf.c
headline
Ld: Fix discarded-qualifiers problems in ldelf.c
tldr
Calvin Owens confirms that their patches to fix discarded-qualifiers warnings in ldelf.c were also independently found and fixed by Mark Wielaard.
proposer
Calvin Owens <calvin@wbinvd.org>
consensus
Ready to Land
outcome
ready
sentiment_score
technical_tradeoffs
  • The patches address compiler warnings, leading to cleaner code.
  • The fixes prevent potential unintended modification of constant data.
  • The impact is relatively small, as the code likely functioned correctly even with the warnings.
series_id
binutils:ld: fix discarded-qualifiers problems in ldelf.c
series_role
reply
series_parts
  • {"title":"ld: Fix discarded-qualifiers problems in ldelf.c","url":"https://inbox.sourceware.org/binutils/20260503123422.GY11304@gnu.wildebeest.org"}
tags
  • binutils
  • linker
  • ld
  • warnings
  • const
bugzilla_url
date
2026-05-03T00:00:00.000Z

Re: [PATCH 4/4] ld: Fix discarded-qualifiers problems in ldelf.c

Calvin Owens responds to Mark Wielaard, noting that the discarded-qualifiers fixes in ldelf.c they submitted were independently discovered and resolved by Mark. Calvin indicates that his patches were created for local testing and offered to save time, but there’s no need for extra effort to use them.