Re: [02/19] RISC-V: fold redundant code in riscv_ip()
Project / Subsystem
binutils / risc-v
Date
2026-05-03
Proposer
Jiawei
Source type
public_inbox
Consensus
Needs Revision
Sentiment
—/10
Technical tradeoffs
- • The original patch simplified the code but introduced a bug.
- • The corrected patch will maintain the original behavior while improving code readability.
All attributes
- project
- binutils
- subsystem
- risc-v
- patch_id
- —
- discussion_id
- 531aa2c8-9442-49eb-90e9-0bf066181673@suse.com
- source_type
- public_inbox
- title
- Re: [02/19] RISC-V: fold redundant code in riscv_ip()
- headline
- RISC-V: fold redundant code in riscv_ip()
- tldr
- Jan Beulich acknowledges and will correct an issue in the RISC-V instruction parsing code identified by Jiawei.
- proposer
- Jiawei
- consensus
- Needs Revision
- outcome
- needs_revision
- sentiment_score
- —
- technical_tradeoffs
-
- • The original patch simplified the code but introduced a bug.
- • The corrected patch will maintain the original behavior while improving code readability.
- series_id
- binutils:risc-v: fold redundant code in riscv_ip()
- series_role
- reply
- series_parts
- []
- tags
-
- • binutils
- • risc-v
- • assembler
- • bugfix
- • review
- bugzilla_url
- —
- date
- 2026-05-03T00:00:00.000Z
Re: [02/19] RISC-V: fold redundant code in riscv_ip()
Jan Beulich responds to a review by Jiawei regarding a patch that folds redundant code in the riscv_ip() function. Jiawei pointed out that the patch inadvertently changed the accepted range of values for the ‘O2’ operand. Jan acknowledges the issue and indicates that they will correct it.