[PATCH 13/23] aarch64: Fix qualifier sequences for cinc/cinv/cneg

Project / Subsystem

binutils / aarch64

Date

2026-05-07

Proposer

Alice Carlotti <alice.carlotti@arm.com>

Source type

public_inbox

Consensus

Proposed

Sentiment

/10

Technical tradeoffs

  • Corrects an existing error in the opcode table.
  • Ensures future compatibility when `AARCH64_OPND_QLF_NIL` is no longer a wildcard.

All attributes

project
binutils
subsystem
aarch64
patch_id
discussion_id
65cd537e-a57a-4d40-6a24-07b495e49fc5@e124511.cambridge.arm.com
source_type
public_inbox
title
[PATCH 13/23] aarch64: Fix qualifier sequences for cinc/cinv/cneg
headline
Aarch64: Fix qualifier sequences for cinc/cinv/cneg
tldr
Correct the qualifier sequences for three-operand cinc/cinv/cneg instructions to prevent future breakage.
proposer
Alice Carlotti <alice.carlotti@arm.com>
consensus
Proposed
outcome
proposed
sentiment_score
technical_tradeoffs
  • Corrects an existing error in the opcode table.
  • Ensures future compatibility when `AARCH64_OPND_QLF_NIL` is no longer a wildcard.
series_id
binutils:aarch64: fix qualifier sequences for cinc/cinv/cneg
series_role
reply
series_parts
[]
tags
  • aarch64
  • assembler
  • opcode table
  • qualifier
  • conditional select
bugzilla_url
date
2026-05-07T00:00:00.000Z

[PATCH 13/23] aarch64: Fix qualifier sequences for cinc/cinv/cneg

This patch corrects the qualifier sequences for the three-operand forms of the cinc, cinv, and cneg instructions in the AArch64 assembler. These instructions were incorrectly using the same qualifier sequences as their four-operand counterparts, leading to an incorrect qualifier being specified for the third operand. This patch replaces the incorrect QL_CSEL sequence with QL_R2NIL, which will become necessary when AARCH64_OPND_QLF_NIL is no longer treated as a wildcard.