[PATCH 02/23] aarch64: Fix use of wrong zero enum value
Project / Subsystem
binutils / aarch64
Date
2026-05-07
Proposer
Alice Carlotti <alice.carlotti@arm.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Corrects a type error, improving code correctness.
- • No performance impact.
All attributes
- project
- binutils
- subsystem
- aarch64
- patch_id
- —
- discussion_id
- f54b2753-a787-9e85-0df8-0c529830ff86@e124511.cambridge.arm.com
- source_type
- public_inbox
- title
- [PATCH 02/23] aarch64: Fix use of wrong zero enum value
- headline
- Aarch64: Fix use of wrong zero enum value
- tldr
- Corrects an enum comparison in `aarch64_get_expected_qualifier` by using `AARCH64_OPND_QLF_NIL` instead of `AARCH64_OPND_NIL`.
- proposer
- Alice Carlotti <alice.carlotti@arm.com>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Corrects a type error, improving code correctness.
- • No performance impact.
- series_id
- binutils:aarch64: fix use of wrong zero enum value
- series_role
- reply
- series_parts
- []
- tags
-
- • aarch64
- • assembler
- • enum
- • type error
- url
- https://inbox.sourceware.org/binutils/f54b2753-a787-9e85-0df8-0c529830ff86@e124511.cambridge.arm.com
- bugzilla_url
- —
- date
- 2026-05-07T00:00:00.000Z
[PATCH 02/23] aarch64: Fix use of wrong zero enum value
This patch corrects an error in aarch64_get_expected_qualifier where an aarch64_opnd_qualifier_t was incorrectly compared against AARCH64_OPND_NIL instead of AARCH64_OPND_QLF_NIL. The incorrect comparison was previously worked around by casting the qualifier to (enum aarch64_opnd). This patch removes the cast and uses the correct enum value for comparison, fixing the underlying type mismatch.