[PATCH 05/23] aarch64: Remove redundant element size checks

Project / Subsystem

binutils / aarch64

Date

2026-05-07

Proposer

Alice Carlotti <alice.carlotti@arm.com>

Source type

public_inbox

Consensus

Proposed

Sentiment

/10

Technical tradeoffs

  • Improved code readability and potentially minor performance improvement by removing redundant checks.
  • Assumes that equality of qualifiers implies equality of element sizes.

All attributes

project
binutils
subsystem
aarch64
patch_id
discussion_id
9aef2ded-6d70-13d7-6977-201dab2cfa44@e124511.cambridge.arm.com
source_type
public_inbox
title
[PATCH 05/23] aarch64: Remove redundant element size checks
headline
Aarch64: Remove redundant element size checks
tldr
Simplifies `get_data_pattern` by removing redundant checks on qualifier element sizes, assuming prior equality checks suffice.
proposer
Alice Carlotti <alice.carlotti@arm.com>
consensus
Proposed
outcome
proposed
sentiment_score
technical_tradeoffs
  • Improved code readability and potentially minor performance improvement by removing redundant checks.
  • Assumes that equality of qualifiers implies equality of element sizes.
series_id
binutils:aarch64: remove redundant element size checks
series_role
reply
series_parts
[]
tags
  • aarch64
  • assembler
  • redundant check
  • code simplification
bugzilla_url
date
2026-05-07T00:00:00.000Z

[PATCH 05/23] aarch64: Remove redundant element size checks

This patch removes redundant checks for element size equality in the get_data_pattern function within opcodes/aarch64-opc.c. Because the code already checks that the qualifiers are equal, checking their element sizes is redundant.