Re: [02/19] RISC-V: fold redundant code in riscv_ip()
Project / Subsystem
binutils / risc-v
Date
2026-05-08
Proposer
Jan Beulich <jbeulich@suse.com>
Source type
public_inbox
Consensus
Under Review
Sentiment
—/10
Technical tradeoffs
- • Renaming internal variables improves code readability but requires careful consideration to avoid breaking existing functionality.
- • Refactoring code can reduce redundancy but may introduce new bugs if not done carefully.
All attributes
- project
- binutils
- subsystem
- risc-v
- patch_id
- —
- discussion_id
- 52e6f372-ecc5-4293-9567-6bf33a718dfd@suse.com
- source_type
- public_inbox
- title
- Re: [02/19] RISC-V: fold redundant code in riscv_ip()
- headline
- RISC-V: fold redundant code in riscv_ip()
- tldr
- Jan fixed an issue reported by Jiawei and suggests a patch to rename 'O4' before applying the main patch for clearer code.
- proposer
- Jan Beulich <jbeulich@suse.com>
- consensus
- Under Review
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Renaming internal variables improves code readability but requires careful consideration to avoid breaking existing functionality.
- • Refactoring code can reduce redundancy but may introduce new bugs if not done carefully.
- series_id
- —
- series_role
- reply
- series_parts
- []
- tags
-
- • RISC-V
- • binutils
- • refactoring
- • instruction pattern matching
- bugzilla_url
- —
- date
- 2026-05-08T00:00:00.000Z
Re: [02/19] RISC-V: fold redundant code in riscv_ip()
Jan Beulich responds to Jiawei’s review of a patch series that folds redundant code in riscv_ip(). He confirms fixing an issue reported, and suggests inserting a patch to rename O4 to O7 for clarity. This would simplify the main patch by avoiding the introduction and immediate removal of a misleading comment.