Re: [02/19] RISC-V: fold redundant code in riscv_ip()
Project / Subsystem
binutils / risc-v
Date
2026-05-09
Proposer
Jiawei <jiawei@iscas.ac.cn>
Source type
public_inbox
Consensus
Under Review
Sentiment
—/10
Technical tradeoffs
- • Improved code readability and maintainability.
- • Potential for subtle changes in behavior due to refactoring, requiring careful testing.
All attributes
- project
- binutils
- subsystem
- risc-v
- patch_id
- —
- discussion_id
- e2f901c6-4690-4381-bd31-377113feb8b3@iscas.ac.cn
- source_type
- public_inbox
- title
- Re: [02/19] RISC-V: fold redundant code in riscv_ip()
- headline
- RISC-V: fold redundant code in riscv_ip()
- tldr
- Jiawei agrees with Jan Beulich's suggestion to rename O4 in a preparatory patch before cleaning up riscv_ip().
- proposer
- Jiawei <jiawei@iscas.ac.cn>
- consensus
- Under Review
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Improved code readability and maintainability.
- • Potential for subtle changes in behavior due to refactoring, requiring careful testing.
- series_id
- —
- series_role
- reply
- series_parts
- []
- tags
-
- • binutils
- • risc-v
- • refactoring
- • assembler
- • disassembler
- bugzilla_url
- —
- date
- 2026-05-09T00:00:00.000Z
Re: [02/19] RISC-V: fold redundant code in riscv_ip()
Jiawei agrees with Jan Beulich’s suggestion to address the misleading name ‘O4’ in the RISC-V instruction parsing code (riscv_ip()) with a preparatory patch before proceeding with the main cleanup patch. This approach aims to make the cleanup process cleaner by avoiding a temporary special case related to the ‘O4’ misnomer.