Re: Starting patch review wiki
Project / Subsystem
gcc / gcc
Date
2026-05-24
Proposer
Andrew Pinski <andrew.pinski@oss.qualcomm.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Suggests using tools that may have false positives, requiring developers to understand and ignore irrelevant warnings.
- • Adds an extra step to the development process, which may slow down contributions if the tools are cumbersome to use.
All attributes
- project
- gcc
- subsystem
- gcc
- patch_id
- —
- discussion_id
- CALvbMcBPnQzpmkhA+Cc34grLxvFbhhEwnhpdFfuyfYZHt6oy3A@mail.gmail.com
- source_type
- public_inbox
- title
- Re: Starting patch review wiki
- headline
- Starting patch review wiki
- tldr
- Andrew Pinski added recommendations to the patch review wiki for new developers to use tools for commit message and coding style correctness.
- proposer
- Andrew Pinski <andrew.pinski@oss.qualcomm.com>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Suggests using tools that may have false positives, requiring developers to understand and ignore irrelevant warnings.
- • Adds an extra step to the development process, which may slow down contributions if the tools are cumbersome to use.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • patch review
- • coding style
- • commit message
- • wiki
- url
- https://inbox.sourceware.org/gcc/CALvbMcBPnQzpmkhA+Cc34grLxvFbhhEwnhpdFfuyfYZHt6oy3A@mail.gmail.com
- bugzilla_url
- —
- date
- 2026-05-24T00:00:00.000Z
Re: Starting patch review wiki
Andrew Pinski added recommendations to the patch review wiki for new developers. These recommendations suggest using tools to ensure commit messages and coding styles are correct, especially for email patch reviews. The wiki also notes that ./contrib/check_GNU_style.py needs improvements, since it flags errors incorrectly in some cases.