[PATCH v3] x86/disasm: do not use format string without format specifiers

← All discussions

Project / Subsystem

binutils / x86/disasm

Date

2026-05-24

Proposer

Will Hawkins <hawkinsw@obs.cr>

Source type

public_inbox

Consensus

Proposed

Sentiment

—/10

Technical tradeoffs

• The patch adds format specifiers to existing calls, ensuring that the code remains functional and secure.

View thread →

All attributes

project: binutils
subsystem: x86/disasm
patch_id: —
discussion_id: 20260524040825.1314911-1-hawkinsw@obs.cr
source_type: public_inbox
title: [PATCH v3] x86/disasm: do not use format string without format specifiers
headline: x86/disasm: Do not use format string without format specifiers
tldr: The x86 disassembler is updated to avoid using format strings without format specifiers, fixing a build failure with -Werror=format-security.
proposer: Will Hawkins <hawkinsw@obs.cr>
consensus: Proposed
outcome: proposed
sentiment_score: —
technical_tradeoffs: • The patch adds format specifiers to existing calls, ensuring that the code remains functional and secure.
series_id: —
series_role: standalone
series_parts: []
tags: • x86
• disassembler
• format string
• security
• build failure
url: https://inbox.sourceware.org/binutils/20260524040825.1314911-1-hawkinsw@obs.cr
bugzilla_url: —
date: 2026-05-24T00:00:00.000Z

[PATCH v3] x86/disasm: do not use format string without format specifiers

This patch modifies the x86 disassembler to avoid using format strings without format specifiers in calls to i386_dis_printf. This resolves a build failure encountered when compiling with the -Werror=format-security flag. The issue was identified as PR binutils/34168.