[PATCH] x86: Pass "%s" to i386_dis_printf as the format string
Project / Subsystem
binutils / x86
Date
2026-05-24
Proposer
"H.J. Lu" <hjl.tools@gmail.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • May require adjustments to existing disassembler tests and scripts.
- • The ->print_address_func() hook limits the possible unification of %rip-relative comments.
All attributes
- project
- binutils
- subsystem
- x86
- patch_id
- —
- discussion_id
- 9a6fd40f-1081-41e3-8050-e000ba78fcfb@suse.com
- source_type
- public_inbox
- title
- [PATCH] x86: Pass "%s" to i386_dis_printf as the format string
- headline
- x86: Pass "%s" to i386_dis_printf as the format string
- tldr
- The x86 disassembler now passes "%s" as the format string to i386_dis_printf to allow comments to be emitted in the same order as operands.
- proposer
- "H.J. Lu" <hjl.tools@gmail.com>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • May require adjustments to existing disassembler tests and scripts.
- • The ->print_address_func() hook limits the possible unification of %rip-relative comments.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • x86
- • disassembler
- • comments
- • formatting
- bugzilla_url
- —
- date
- 2026-05-24T00:00:00.000Z
[PATCH] x86: Pass "%s" to i386_dis_printf as the format string
This patch modifies the x86 disassembler to pass “%s” as the format string to i386_dis_printf. This change should allow comments to be emitted in the same order as operands for better readability. The patch also includes updates to the testsuite to account for the change in comment formatting.