Re: [PATCH] LD/testsuite: Remove $LDFLAGS reference from `run_ld_link_tests'
Project / Subsystem
binutils / ld/testsuite
Date
2026-07-23
Proposer
"Maciej W. Rozycki" <macro@orcam.me.uk>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Test Correctness: Ensuring the test suite accurately reflects linker behavior without unintended side effects from its own configuration.
- • Regression Fix: Reverting an undesirable side effect of a previous commit to maintain expected functionality.
- • Cross-Target Consistency: Maintaining correct test behavior across various architecture targets.
All attributes
- project
- binutils
- subsystem
- ld/testsuite
- patch_id
- —
- discussion_id
- alpine.DEB.2.21.2607232004200.14485@angie.orcam.me.uk
- source_type
- public_inbox
- title
- Re: [PATCH] LD/testsuite: Remove $LDFLAGS reference from `run_ld_link_tests'
- headline
- LD/testsuite: Remove $LDFLAGS reference from `run_ld_link_tests'
- tldr
- Patch removes $LDFLAGS from linker test suite invocations, correcting a regression that caused flags to be duplicated.
- proposer
- "Maciej W. Rozycki" <macro@orcam.me.uk>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Test Correctness: Ensuring the test suite accurately reflects linker behavior without unintended side effects from its own configuration.
- • Regression Fix: Reverting an undesirable side effect of a previous commit to maintain expected functionality.
- • Cross-Target Consistency: Maintaining correct test behavior across various architecture targets.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • binutils
- • linker
- • testsuite
- • regression
- • LDFLAGS
- bugzilla_url
- —
- date
- 2026-07-23T00:00:00.000Z
Re: [PATCH] LD/testsuite: Remove $LDFLAGS reference from `run_ld_link_tests'
This discussion confirms and accepts a patch that removes the $LDFLAGS variable reference from the run_ld_link_tests function in binutils’ testsuite. This corrects a regression introduced by a previous commit (740341b9be65) which caused link flags to be unintentionally duplicated, affecting tests on specific architectures like hppa64-hp-hpux. The change ensures test suite consistency and correctness.