[PATCH 3/4] x86: helper function + variables for templates' ->operand_types[] accesses

Project / Subsystem

binutils / x86

Date

2026-07-24

Proposer

Jan Beulich <jbeulich@suse.com>

Source type

public_inbox

Consensus

Proposed

Sentiment

/10

Technical tradeoffs

  • Introduces a slight indirection for accessing operand types to prepare for a larger refactoring.
  • Simplifies future changes by centralizing operand type access logic.

All attributes

project
binutils
subsystem
x86
patch_id
discussion_id
54396697-ca30-4b9e-b1a8-b80284dec395@suse.com
source_type
public_inbox
title
[PATCH 3/4] x86: helper function + variables for templates' ->operand_types[] accesses
headline
x86: helper function + variables for templates' ->operand_types[] accesses
tldr
Introduces a helper function to access operand types, preparing for their removal from instruction templates.
proposer
Jan Beulich <jbeulich@suse.com>
consensus
Proposed
outcome
proposed
sentiment_score
technical_tradeoffs
  • Introduces a slight indirection for accessing operand types to prepare for a larger refactoring.
  • Simplifies future changes by centralizing operand type access logic.
series_id
binutils:x86: helper function + variables for templates' ->operand_types[] accesses
series_role
reply
series_parts
[]
tags
  • x86
  • gas
  • refactoring
  • code-quality
bugzilla_url
date
2026-07-24T00:00:00.000Z

[PATCH 3/4] x86: helper function + variables for templates' ->operand_types[] accesses

As part of a series to refactor x86 instruction templates, Jan Beulich introduces a helper function get_operand_types in tc-i386.c. This function is designed to abstract away the direct access to insn_template->operand_types, serving as a preparatory step for moving this data out of the template structure itself. This change aims to reduce churn in subsequent modifications.