[PATCH] libctf,libsframe: remove include of config.h
Project / Subsystem
binutils / binutils
Date
2026-08-11
Proposer
Andrew Burgess <aburgess@redhat.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Resolves duplicate definition warnings during in-source builds.
- • Relies on the build system correctly generating `libctf/config.h` before it's needed by `libsframe` components that use `libctf`'s functionality.
All attributes
- project
- binutils
- subsystem
- binutils
- patch_id
- —
- discussion_id
- 27dfa5e4c684cfdd773e207e8022234109eb1b91.1786465076.git.aburgess@redhat.com
- source_type
- public_inbox
- title
- [PATCH] libctf,libsframe: remove include of config.h
- headline
- libctf,libsframe: remove include of config.h
- tldr
- Fixes duplicate config.h includes in libctf/libsframe build when building in-source.
- proposer
- Andrew Burgess <aburgess@redhat.com>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Resolves duplicate definition warnings during in-source builds.
- • Relies on the build system correctly generating `libctf/config.h` before it's needed by `libsframe` components that use `libctf`'s functionality.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • build
- • binutils
- • libctf
- • libsframe
- • gdb
- bugzilla_url
- —
- date
- 2026-08-11T00:00:00.000Z
[PATCH] libctf,libsframe: remove include of config.h
Andrew Burgess proposes to remove the inclusion of config.h from libctf/swap.h to resolve duplicate definition warnings that occur during in-source builds of GDB. The issue arises because libsframe/config.h is included first, and then a subsequent build of libctf creates libctf/config.h, leading to conflicts. Removing the libctf/swap.h include eliminates these warnings.