Re: [PATCH] microblaze: don't index the local symbol cache with a global symbol index
Project / Subsystem
binutils / microblaze
Date
2026-08-12
Proposer
Alan Modra <amodra@gmail.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Fixes an out-of-bounds read, preventing silent corruption of relocation addends.
- • Simplifies the `microblaze_elf_relax_section` function by removing unnecessary global symbol lookups.
All attributes
- project
- binutils
- subsystem
- microblaze
- patch_id
- —
- discussion_id
- anwpt0exztiKYco9@squeak.grove.modra.org
- source_type
- public_inbox
- title
- Re: [PATCH] microblaze: don't index the local symbol cache with a global symbol index
- headline
- microblaze: don't index the local symbol cache with a global symbol index
- tldr
- Reviewer suggests a tidy-up to a patch that fixes an out-of-bounds read in microblaze ELF relaxation by ensuring global symbols are not indexed.
- proposer
- Alan Modra <amodra@gmail.com>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Fixes an out-of-bounds read, preventing silent corruption of relocation addends.
- • Simplifies the `microblaze_elf_relax_section` function by removing unnecessary global symbol lookups.
- series_id
- —
- series_role
- reply
- series_parts
- []
- tags
-
- • binutils
- • microblaze
- • linker
- • elf
- • relocations
- bugzilla_url
- —
- date
- 2026-08-12T00:00:00.000Z
Re: [PATCH] microblaze: don't index the local symbol cache with a global symbol index
Alan Modra reviews a patch that fixes an out-of-bounds read in microblaze ELF relaxation by adding a missing bounds check. He agrees with the fix, noting that the symtab_hdr->contents buffer should only contain local symbols. Modra suggests a further tidy-up to the patch, removing the need to re-read global symbols entirely, as they are not used within the microblaze_elf_relax_section function.