Re: [PATCH] libctf,libsframe: remove include of config.h
Project / Subsystem
binutils / binutils
Date
2026-08-14
Proposer
Indu Bhagat <ibhagatgnu@gmail.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Resolving duplicate definition warnings and simplifying includes vs. the clarity of having an explicit include for config.h.
All attributes
- project
- binutils
- subsystem
- binutils
- patch_id
- —
- discussion_id
- ff90d851-ba7d-47be-998f-41559ad806ce@gmail.com
- source_type
- public_inbox
- title
- Re: [PATCH] libctf,libsframe: remove include of config.h
- headline
- libctf,libsframe: remove include of config.h
- tldr
- Removes redundant include of config.h in libsframe/sframe.c to fix duplicate definition warnings during recompilation.
- proposer
- Indu Bhagat <ibhagatgnu@gmail.com>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Resolving duplicate definition warnings and simplifying includes vs. the clarity of having an explicit include for config.h.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • build system
- • dependencies
- • compiler warnings
- • binutils
- • reproducibility
- bugzilla_url
- —
- date
- 2026-08-14T00:00:00.000Z
Re: [PATCH] libctf,libsframe: remove include of config.h
This patch addresses a build issue where recompiling libsframe/sframe.c after the initial build results in duplicate definition warnings (e.g., ‘PACKAGE’ redefined). The problem occurs because sframe.c includes config.h twice: once from libsframe/config.h (which exists after the initial configure) and again via libctf/swap.h which includes libctf/config.h. By removing the direct include of config.h in libsframe/sframe.c, the patch resolves the warning without affecting functionality.