[PATCH/BUG] ld/Makefile.am: missing dependency on ldscripts/stamp for e%.c target

Project / Subsystem

binutils / ld/makefile.am

Date

2026-08-15

Proposer

A B C <ddupard68@gmail.com>

Source type

public_inbox

Consensus

Proposed

Sentiment

—/10

Technical tradeoffs

  • • Ensuring build correctness and robustness against parallel build environments vs. potentially adding minor overhead to the build process due to an extra dependency check.

All attributes

project
binutils
subsystem
ld/makefile.am
patch_id
—
discussion_id
CACtFPF0gq-TtGy1fAOQnZE=auqP-w3mn2uT=ebLBStV928ZCdg@mail.gmail.com
source_type
public_inbox
title
[PATCH/BUG] ld/Makefile.am: missing dependency on ldscripts/stamp for e%.c target
headline
ld/Makefile.am: missing dependency for e%.c target
tldr
Fixes a build issue in ld/Makefile.am where genscripts.sh runs before the ldscripts/ directory is created, causing build failures.
proposer
A B C <ddupard68@gmail.com>
consensus
Proposed
outcome
proposed
sentiment_score
—
technical_tradeoffs
  • • Ensuring build correctness and robustness against parallel build environments vs. potentially adding minor overhead to the build process due to an extra dependency check.
series_id
—
series_role
standalone
series_parts
[]
tags
  • • build system
  • • makefile
  • • linker
  • • binutils
  • • race condition
bugzilla_url
—
date
2026-08-15T00:00:00.000Z

[PATCH/BUG] ld/Makefile.am: missing dependency on ldscripts/stamp for e%.c target

A bug in ld/Makefile.am prevents the correct generation of emulation C sources (e%.c). The rule for creating these files runs genscripts.sh before the ldscripts/ directory and its stamp file are created, leading to build failures with missing file errors. This patch proposes adding $(GEN_DEPENDS) or ldscripts/stamp as a prerequisite to the e%.c target to ensure the directory exists before genscripts.sh is executed.