Re: [PATCH v2 0/2] bpf: fix gotol with a signed offset, and run the spacing test
Project / Subsystem
binutils / bpf
Date
2026-09-03
Proposer
Vineet Gupta <vineet.gupta@linux.dev>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • The fix ensures compatibility with libbpf and potentially other tools that rely on correct `gotol` instruction assembly, improving the reliability of BPF program loading.
- • Enabling the `spacing-pseudoc` test case improves test coverage for the BPF assembler, helping to catch future regressions.
All attributes
- project
- binutils
- subsystem
- bpf
- patch_id
- —
- discussion_id
- 7f87eb3f-d970-417b-a1db-5eb72fcdde8d@linux.dev
- source_type
- public_inbox
- title
- Re: [PATCH v2 0/2] bpf: fix gotol with a signed offset, and run the spacing test
- headline
- bpf: fix gotol with a signed offset, and run the spacing test
- tldr
- Fixes BPF assembler misassembly of `gotol` with signed offsets and enables a related test case.
- proposer
- Vineet Gupta <vineet.gupta@linux.dev>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • The fix ensures compatibility with libbpf and potentially other tools that rely on correct `gotol` instruction assembly, improving the reliability of BPF program loading.
- • Enabling the `spacing-pseudoc` test case improves test coverage for the BPF assembler, helping to catch future regressions.
- series_id
- binutils:bpf: fix gotol with a signed offset, and run the spacing test
- series_role
- cover
- series_parts
- []
- tags
-
- • binutils
- • gas
- • bpf
- • assembler
- • regression-test
- bugzilla_url
- —
- date
- 2026-09-03T00:00:00.000Z
Re: [PATCH v2 0/2] bpf: fix gotol with a signed offset, and run the spacing test
This patch series addresses two issues in the BPF backend of the GNU Assembler (gas). First, it fixes a bug where gotol + imm was misassembled as goto label + imm, leading to runtime failures in libbpf. Second, it enables a previously disabled test case, spacing-pseudoc.s/.d, which is relevant to testing jump instructions. The author notes that a proposed solution using %W for whitespace did not work due to how gas parses operands.