Re: [PATCH v2 2/2] PR 34558: bpf: don't mis-assemble `gotol' with signed offset
Project / Subsystem
binutils / binutils
Date
2026-09-04
Proposer
Vineet Gupta <vineet.gupta@linux.dev>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Reordering the opcode table is a less invasive change than modifying the core parsing logic.
- • Ensures compatibility with existing BPF assembly syntax, including flexible spacing.
All attributes
- project
- binutils
- subsystem
- binutils
- patch_id
- —
- discussion_id
- 4bad5b00-5758-4b73-a49a-aaba5022b5b9@linux.dev
- source_type
- public_inbox
- title
- Re: [PATCH v2 2/2] PR 34558: bpf: don't mis-assemble `gotol' with signed offset
- headline
- BPF assembler: Fix `gotol' and `goto' mnemonic parsing
- tldr
- Corrects BPF assembler to handle `gotol' and `goto' mnemonics with flexible spacing and signed offsets.
- proposer
- Vineet Gupta <vineet.gupta@linux.dev>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Reordering the opcode table is a less invasive change than modifying the core parsing logic.
- • Ensures compatibility with existing BPF assembly syntax, including flexible spacing.
- series_id
- binutils:pr 34558: bpf: don't mis-assemble `gotol' with signed offset
- series_role
- reply
- series_parts
-
- • {"title":"PR 34558: bpf: don't mis-assemble `gotol' with signed offset","url":"https://inbox.sourceware.org/binutils/8733vq2vzy.fsf@gnu.org"}
- tags
-
- • bpf
- • assembler
- • parsing
- • goto
- • linker
- bugzilla_url
- —
- date
- 2026-09-04T00:00:00.000Z
Re: [PATCH v2 2/2] PR 34558: bpf: don't mis-assemble `gotol' with signed offset
Vineet Gupta and Jose E. Marchesi discuss the nuances of parsing BPF assembler instructions, specifically the goto and gotol mnemonics. The conversation clarifies that the assembler must support flexible spacing around operands and signs, and that whitespace handling by gas can interfere with this. They explore solutions involving reordering opcode tables to correctly assemble instructions like gotol and goto with signed offsets, addressing issues highlighted in PR 34558.