Re: [PATCH v3 1/5] gas: bpf: actually run the pseudo-C spacing test
Project / Subsystem
binutils / gas
Date
2026-09-08
Proposer
Vineet Gupta <vineet.gupta@linux.dev>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Enables previously untested code, improving overall test coverage.
- • Fixes a byte-order mismatch, ensuring accurate assembly for little-endian targets.
- • Reflects correct assembly behavior for instructions with flexible spacing.
All attributes
- project
- binutils
- subsystem
- gas
- patch_id
- —
- discussion_id
- 55e2d94e-d089-4f29-8b6d-93e7964fd66a@linux.dev
- source_type
- public_inbox
- title
- Re: [PATCH v3 1/5] gas: bpf: actually run the pseudo-C spacing test
- headline
- BPF gas: Run pseudo-C spacing test
- tldr
- BPF gas pseudo-C spacing tests are now executed, fixing byte order issues and ensuring correct assembly.
- proposer
- Vineet Gupta <vineet.gupta@linux.dev>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Enables previously untested code, improving overall test coverage.
- • Fixes a byte-order mismatch, ensuring accurate assembly for little-endian targets.
- • Reflects correct assembly behavior for instructions with flexible spacing.
- series_id
- binutils:gas: bpf: actually run the pseudo-c spacing test
- series_role
- reply
- series_parts
-
- • {"title":"gas: bpf: actually run the pseudo-C spacing test","url":"https://inbox.sourceware.org/binutils/87qzj546y5.fsf@gnu.org"}
- • {"title":"gas: bpf: actually run the pseudo-C spacing test","url":"https://inbox.sourceware.org/binutils/20260907091102.2595057-2-vineet.gupta@linux.dev"}
- tags
-
- • BPF
- • gas
- • assembler
- • testing
- • byte order
- bugzilla_url
- —
- date
- 2026-09-08T00:00:00.000Z
Re: [PATCH v3 1/5] gas: bpf: actually run the pseudo-C spacing test
This patch enables the execution of BPF gas pseudo-C spacing tests by adding them to the bpf.exp test suite. Previously, these tests were never run, leading to undiscovered issues. Enabling them revealed a byte order problem where the test declared big-endian assembly (-EB) but expected little-endian output. The patch corrects this by setting the assembler to little-endian (-EL), aligning the test with its expected encodings and filename. This ensures proper assembly of instructions with flexible spacing, such as goto+1 and conditional jumps.