Re: [PATCH v4 3/4] gas: bpf: test `gotol' in a compound conditional
Project / Subsystem
binutils / gas
Date
2026-09-08
Proposer
"Jose E. Marchesi" <jemarch@gnu.org>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Ensures correct assembly of `gotol` within compound conditional jumps.
- • Adds test coverage for a previously untested scenario.
- • Validates the effectiveness of the `%t` specifier in distinguishing similar mnemonics.
All attributes
- project
- binutils
- subsystem
- gas
- patch_id
- —
- discussion_id
- 87o6e7syqp.fsf@gnu.org
- source_type
- public_inbox
- title
- Re: [PATCH v4 3/4] gas: bpf: test `gotol' in a compound conditional
- headline
- BPF gas: Test `gotol` in compound conditional jumps
- tldr
- BPF gas now includes a test case for `gotol` within compound conditional jumps, ensuring correct parsing and assembly.
- proposer
- "Jose E. Marchesi" <jemarch@gnu.org>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Ensures correct assembly of `gotol` within compound conditional jumps.
- • Adds test coverage for a previously untested scenario.
- • Validates the effectiveness of the `%t` specifier in distinguishing similar mnemonics.
- series_id
- binutils:gas: bpf: test `gotol' in a compound conditional
- series_role
- reply
- series_parts
-
- • {"title":"gas: bpf: test `gotol' in a compound conditional","url":"https://inbox.sourceware.org/binutils/20260908062940.2734221-4-vineet.gupta@linux.dev"}
- • {"title":"gas: bpf: test `gotol' in a compound conditional","url":"https://inbox.sourceware.org/binutils/20260907091102.2595057-5-vineet.gupta@linux.dev"}
- tags
-
- • BPF
- • gas
- • assembler
- • testing
- • control flow
- bugzilla_url
- —
- date
- 2026-09-08T00:00:00.000Z
Re: [PATCH v4 3/4] gas: bpf: test `gotol' in a compound conditional
This patch adds a new test case to the BPF assembler’s test suite to specifically cover the gotol instruction when used within compound conditional jumps. The existing fix for gotol only addressed standalone instances; compound conditional jumps embed a goto%w%d16 form, making them susceptible to misassembly without this dedicated test. The new test verifies that the assembler correctly handles these scenarios, preventing silent failures and incorrect relocations.