[PATCH 1/4] bfd: pe: Clarify pe_print_pdata() conditional
Project / Subsystem
binutils / bfd
Date
2026-09-13
Proposer
Jon Turney <jon.turney@dronecode.org.uk>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Improves code clarity and documentation.
- • Identifies potential bugs and security issues related to `.pdata` handling.
All attributes
- project
- binutils
- subsystem
- bfd
- patch_id
- —
- discussion_id
- 20260913123323.9734-2-jon.turney@dronecode.org.uk
- source_type
- public_inbox
- title
- [PATCH 1/4] bfd: pe: Clarify pe_print_pdata() conditional
- headline
- bfd: pe: Clarify pe_print_pdata() conditional
- tldr
- Clarify and correct the conditional logic in PE .pdata printing.
- proposer
- Jon Turney <jon.turney@dronecode.org.uk>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Improves code clarity and documentation.
- • Identifies potential bugs and security issues related to `.pdata` handling.
- series_id
- binutils:bfd: pe: clarify pe_print_pdata() conditional
- series_role
- reply
- series_parts
- []
- tags
-
- • bfd
- • pe
- • pdata
- • clarification
- • code quality
- bugzilla_url
- —
- date
- 2026-09-13T00:00:00.000Z
[PATCH 1/4] bfd: pe: Clarify pe_print_pdata() conditional
This patch clarifies the conditional logic within the pe_print_pdata function in bfd/peXXigen.c. It updates comments to reflect the function’s intended behavior and identifies that the existing conditional is pointless, as PE MIPS support was removed. The change also highlights potential issues with the pdata entry size for ia64 and unconstrained reads, suggesting that the current implementation may be incorrect or unsafe for certain architectures.