[PATCH] binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
Project / Subsystem
binutils / binutils
Date
2026-09-15
Proposer
Jan Dubiec <jdx@o2.pl>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Ensuring test suite reliability across different operating systems.
- • Managing the intricacies of environment-specific argument processing (MSYS2 path conversion).
All attributes
- project
- binutils
- subsystem
- binutils
- patch_id
- —
- discussion_id
- 20260915053021.234582-1-jdx@o2.pl
- source_type
- public_inbox
- title
- [PATCH] binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
- headline
- Fix objdump --source-comment test on Windows
- tldr
- Fixes objdump test case failure on Windows due to path argument conversion.
- proposer
- Jan Dubiec <jdx@o2.pl>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- —
- technical_tradeoffs
-
- • Ensuring test suite reliability across different operating systems.
- • Managing the intricacies of environment-specific argument processing (MSYS2 path conversion).
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • binutils
- • testsuite
- • windows
- • objdump
- • msys2
- bugzilla_url
- —
- date
- 2026-09-15T00:00:00.000Z
[PATCH] binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
A test case for objdump --source-comment is failing on Windows within the MSYS2 environment. This failure occurs because MSYS2 automatically converts Unix-style paths to Windows-style paths in command-line arguments, resulting in a single slash being passed to objdump instead of the expected double slash. This patch addresses the issue by conditionally excluding --source-comment= from this automatic conversion for Windows hosts.