Re: [PATCH] binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
Project / Subsystem
binutils / binutils
Date
2026-09-18
Proposer
Jan Beulich <jbeulich@suse.com>
Source type
public_inbox
Consensus
Proposed
Sentiment
—/10
Technical tradeoffs
- • Fixes a specific test case failure on Windows.
- • Uses environment variable manipulation, which might be fragile or have unintended side effects.
- • The reviewer suggests a potentially more robust method of handling environment variables.
All attributes
- project
- binutils
- subsystem
- binutils
- patch_id
- —
- discussion_id
- 2f1d1589-5698-432b-8525-d659c01fe288@suse.com
- source_type
- public_inbox
- title
- Re: [PATCH] binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
- headline
- binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
- tldr
- Adjusts objdump test case for Windows to prevent path conversion issues with MSYS2.
- proposer
- Jan Beulich <jbeulich@suse.com>
- consensus
- Proposed
- outcome
- needs_revision
- sentiment_score
- —
- technical_tradeoffs
-
- • Fixes a specific test case failure on Windows.
- • Uses environment variable manipulation, which might be fragile or have unintended side effects.
- • The reviewer suggests a potentially more robust method of handling environment variables.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • objdump
- • testsuite
- • Windows
- • MSYS2
- • cross-platform
- bugzilla_url
- —
- date
- 2026-09-18T00:00:00.000Z
Re: [PATCH] binutils: testsuite: Fix "objdump --source-comment" test case on Windows.
A test case for objdump --source-comment fails on Windows due to MSYS2’s automatic conversion of Unix-style paths to Windows-style paths, which alters the expected double slash to a single slash. This patch attempts to fix the issue by using MSYS2_ARG_CONV_EXCL to prevent this conversion for the --source-comment= argument. A reviewer questions the approach, suggesting appending to the environment variable might be more robust.