[RFC] gas: testsuite: How to fix gas/all/pr27381 on Windows?
Project / Subsystem
binutils / gas
Date
2026-09-21
Proposer
Jan Dubiec <jdx@o2.pl>
Source type
public_inbox
Consensus
Proposed
Sentiment
7/10
Technical tradeoffs
- • XFAILing the test sacrifices correctness verification on Windows.
- • Modifying the regex is a minimal change but might mask other issues.
- • Adding a `stat` check before `fopen` increases code complexity but improves cross-platform robustness.
All attributes
- project
- binutils
- subsystem
- gas
- patch_id
- —
- discussion_id
- bca8c37d-95a0-4c6a-87e7-b97241a34c4b@o2.pl
- source_type
- public_inbox
- title
- [RFC] gas: testsuite: How to fix gas/all/pr27381 on Windows?
- headline
- gas: testsuite: How to fix gas/all/pr27381 on Windows?
- tldr
- Discussion on how to fix a failing gas testcase (pr27381) on Windows due to differences in `fopen` and `fstat` behavior compared to POSIX systems.
- proposer
- Jan Dubiec <jdx@o2.pl>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- 7
- technical_tradeoffs
-
- • XFAILing the test sacrifices correctness verification on Windows.
- • Modifying the regex is a minimal change but might mask other issues.
- • Adding a `stat` check before `fopen` increases code complexity but improves cross-platform robustness.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • gas
- • Windows
- • portability
- • testsuite
- • file handling
- bugzilla_url
- —
- date
- 2026-09-21T00:00:00.000Z
[RFC] gas: testsuite: How to fix gas/all/pr27381 on Windows?
Jan Dubiec is seeking community input on how to fix the gas/all/pr27381 test case, which fails on Windows. The failure stems from platform-specific behavior of fopen and subsequent fstat calls when handling file paths, leading to different error messages and control flow than on POSIX systems. Three potential solutions are proposed: XFAILing the test on Windows, adjusting the expected regular expression, or adopting a more involved approach by checking file types with stat before opening.