[PATCH] ld/pdb: Terminate the string list in S_ENVBLOCK

← All discussions

Project / Subsystem

binutils / ld/pdb

Date

2026-09-30

Proposer

Oleg Tolmatcev <oleg.tolmatcev@gmail.com>

Source type

public_inbox

Consensus

Proposed

Sentiment

—/10

View thread →

All attributes

project: binutils
subsystem: ld/pdb
patch_id: —
discussion_id: 20260930193657.733-14-oleg.tolmatcev@gmail.com
source_type: public_inbox
title: [PATCH] ld/pdb: Terminate the string list in S_ENVBLOCK
headline: ld/pdb: Terminate string list in S_ENVBLOCK
tldr: Adds a null terminator to the string list in S_ENVBLOCK symbols to fix parsing errors.
proposer: Oleg Tolmatcev <oleg.tolmatcev@gmail.com>
consensus: Proposed
outcome: proposed
sentiment_score: —
technical_tradeoffs: []
series_id: —
series_role: standalone
series_parts: []
tags: • pdb
• linker
• debugging
• bugfix
url: https://inbox.sourceware.org/binutils/20260930193657.733-14-oleg.tolmatcev@gmail.com
bugzilla_url: —
date: 2026-09-30T00:00:00.000Z

[PATCH] ld/pdb: Terminate the string list in S_ENVBLOCK

This patch addresses an issue where the list of strings in an S_ENVBLOCK symbol was not properly terminated, leading to parsing errors when the strings ended on a four-byte boundary. Specifically, it adds a null terminator to the string list, preventing readers like llvm-pdbutil from running off the end of the record and reporting “Stream Error”.