Landing: 8a676181f7b8
Project / Subsystem
binutils / binutils/gas
Date
2026-06-06
Author
Alan Modra
Commit
8a676181f7b8e520c205c10b82d6b24a3a9cf431
Source
public_inbox
Perf win
No
Breaking
No
All attributes
- project
- binutils
- subsystem
- binutils/gas
- patch_id
- —
- commit_hash
- 8a676181f7b8e520c205c10b82d6b24a3a9cf431
- source_type
- public_inbox
- headline
- Fix for `s_comm_internal` uninitialized access in GAS.
- tldr
- GAS now avoids uninitialized access in `s_comm_internal` by preventing double-calls to line-ending consumption functions after errors.
- author
- Alan Modra
- outcome
- committed
- performance_win
- false
- breaking_change
- false
- series_id
- —
- series_parts
- []
- tags
-
- • bugfix
- • assembler
- • memory safety
- discussion_id_link
- —
- bugzilla_pr
- —
- date
- 2026-06-06T00:00:00.000Z
This commit addresses a bug in the GNU Assembler (GAS) where s_comm_internal could attempt to access uninitialized memory. The issue arose when elf_common_parse called ignore_rest_of_line after an error, and then s_comm_internal subsequently called demand_empty_rest_of_line. Both functions consume the end-of-statement character, leading the second call to potentially read from an invalid memory region. The fix prevents elf_common_parse from calling ignore_rest_of_line to avoid this double-consumption and ensure correct input parsing.