Landing: 3385e12cefe0

← All landings

Project / Subsystem

gcc / gccrs

Date

2026-06-21

Author

Pierre-Emmanuel Patry

Commit

3385e12cefe006b3f0164ce0db8b198ff1373452

Source

github

Perf win

Breaking

View on GitHub →

All attributes

project: gcc
subsystem: gccrs
patch_id: —
commit_hash: 3385e12cefe006b3f0164ce0db8b198ff1373452
source_type: github
headline: Revert optional lang item segment name.
tldr: Restores mandatory language item segment names to ensure accurate AST dumping in gccrs.
author: Pierre-Emmanuel Patry
outcome: committed
performance_win: false
breaking_change: false
series_id: —
series_parts: []
tags: • gccrs
• rust
• AST
• compiler internals
discussion_id_link: —
bugzilla_pr: —
url: https://github.com/gcc-mirror/gcc/commit/3385e12cefe006b3f0164ce0db8b198ff1373452
date: 2026-06-21T00:00:00.000Z

This commit reverts changes that made language item segment names optional in gccrs. It was found that these names are not fixed and are declared within the core crate. Making them optional prevented accurate dumping of the Abstract Syntax Tree (AST), as the exact paths to language items could not be reconstructed. The segment name argument has been added back to relevant AST builder functions.