Landing: cb23e7f1a781

← All landings

Project / Subsystem

gcc / gccrs

Date

2026-08-15

Author

Philip Herron

Commit

cb23e7f1a781ed2307e975d084fbd4804d3c0a63

Source

github

Perf win

Breaking

View on GitHub →

All attributes

project: gcc
subsystem: gccrs
patch_id: —
commit_hash: cb23e7f1a781ed2307e975d084fbd4804d3c0a63
source_type: github
headline: gccrs: Fix missing error diag on const parser and crash in typecheck
tldr: Fixes parsing and type-checking errors in gccrs related to constant expressions.
author: Philip Herron
outcome: committed
performance_win: false
breaking_change: false
series_id: —
series_parts: []
tags: • gccrs
• parsing
• type checking
• constants
• rust
discussion_id_link: —
bugzilla_pr: —
url: https://github.com/gcc-mirror/gcc/commit/cb23e7f1a781ed2307e975d084fbd4804d3c0a63
date: 2026-08-15T00:00:00.000Z

This commit addresses two critical issues in gccrs: a missing error diagnostic during the parsing of constant expressions and a crash during type checking when evaluating constants. The fix ensures that the parser correctly handles default expressions by forcing braces, and that the type checker can safely evaluate constants even when type checking fails, preventing crashes caused by invalid error nodes. This resolves Rust-GCC/gccrs#4173.