Review Request: Rename Arm v8/v9 Architecture Tags
Richard Earnshaw reviews a patch renaming Arm AEABI CPU architecture tags to include the profile suffix for A-profile architectures and requests an indentation…
Richard Earnshaw reviews a patch from Sivan Shani that renames the Arm AEABI CPU architecture tag constants and macro definitions to include the profile suffix for A-profile architectures, making the naming consistent with existing v8-R and v8-M tag names. Earnshaw requests a minor indentation fix in bfd/cpu-arm.c.
- reviewer
Requests an indentation fix for the second and third elements in `bfd/cpu-arm.c`.
“Please check the indentation here of the second and third elements; they should be aligned in the columns.”
In Details
This patch renames architecture tags within the GNU Binutils, specifically affecting the BFD (Binary File Descriptor) library, the GNU Assembler (gas), and the gold linker. The tags represent different ARM architecture versions (v8 and v9) and profiles (A, R, M). The change aims to standardize the naming convention by including the profile suffix for A-profile architectures. This is primarily a code organization and readability improvement.
For Context
This discussion concerns changes to the way the Binutils (a suite of tools for working with binary files) identifies different versions of the ARM processor architecture. The patch renames some internal names to make them more consistent and easier to understand. This change primarily affects developers working on the Binutils tools themselves, rather than users of those tools.