Handle NULL return from bfd_alloc/zalloc in elf.c
Adds checks for NULL return values from bfd_alloc and bfd_zalloc in elf.c to prevent potential crashes.
This patch addresses a potential issue in binutils’ elf.c by adding checks for NULL return values from bfd_zalloc and bfd_alloc calls. It also removes unnecessary casts on the return values of these allocation functions and simplifies variable usage in a few cases, aiming to improve robustness.
- proposer
Submits a patch to elf.c that adds checks for NULL return values from `bfd_zalloc` and `bfd_alloc` calls, fixes PR 34131, and removes unnecessary casts.
“ PR 34131 * elf.c: Remove unnecessary casts on bfd_[zm]*alloc return value. Do without "amt" temp var in a few cases. (assign_section_numbers): Check for NULL return from bfd_zalloc. (elfobj_grok_stapsdt_note_1): Likewise for bfd_alloc.”
In Details
This patch for binutils' elf.c addresses Potential Bug Report (PR) 34131 by adding crucial null-pointer checks for memory allocations made via bfd_zalloc and bfd_alloc. It also cleans up the code by removing redundant type casts on the return values of these functions and consolidating temporary variables. These changes enhance the robustness of the ELF file parsing in binutils, preventing potential crashes if memory allocation fails.
- elf.c
- A C source file within the binutils project that handles the parsing and manipulation of ELF (Executable and Linkable Format) object files.
- bfd_alloc
- A function within the BFD (Binary File Descriptor) library used for general-purpose memory allocation.
- bfd_zalloc
- Similar to bfd_alloc, but
bfd_zalloczeroes the allocated memory. - NULL return
- When a memory allocation function fails, it typically returns a NULL pointer instead of a valid memory address.
- PR 34131
- A bug report identifier within the binutils project's tracking system, indicating a specific issue that this patch aims to fix.
- type casts
- Explicit conversions in programming code that change a value from one data type to another. In this context, removing them suggests the casts were unnecessary due to implicit type compatibility.