gas: Add AArch64 Windows SEH (pdata/xdata) support
Reviewer questions a resubmitted patch for AArch64 SEH support due to an existing, similar patch.
Jan Beulich questions a resubmitted patch for AArch64 Windows SEH support in gas, noting that similar work is already in progress (v12) and that the author might need to provide a Statement of Biography (S-o-B) if they are not a known contributor. The original author, responding to Beulich’s previous comments, explains that the patch was resubmitted due to an unblocked port and that previous bugs were distinct from x86_64 issues.
- other
Explains that the resubmitted patch addresses different bugs than a previous one and was resent due to port issues.
“Hi. The previous patch has other bugs that would break seh on x86_64 so they are not the same patch, the first one needs to be discarded + i did not use git send-email because the 587 port was blocked so i resubmitted it again. Not deliberately try to insult other devs.”
- reviewer
Queries the resubmission of the patch, pointing out an existing similar patch and suggesting a need for a Statement of Biography.
“Please can you comment then on that patch? Re-starting from scratch is an option if the other one is excessively broken, yet even then comments given there on earlier versions would want taking into account in such a full re-do.”
Technical Tradeoffs
- Ensures proper SEH support for AArch64 on Windows, crucial for application compatibility.
- The resubmission process and review concerns might delay the integration of this important feature.
In Details
Reviewer Jan Beulich expresses concern about a resubmitted patch adding AArch64 Windows SEH support to gas. The concern stems from a similar, earlier patch (v12) and potential requirements for a Statement of Biography (S-o-B). The proposer clarifies that the current patch addresses distinct issues and was resent due to external factors.
- gas
- The GNU Assembler, responsible for converting assembly language code into machine code.
- AArch64
- The 64-bit execution state of the ARM architecture.
- SEH
- Structured Exception Handling, a mechanism for handling errors and exceptions in Windows operating systems.
- pdata/xdata
- Data structures used in Windows exception handling to describe function unwind information.
- Statement of Biography (S-o-B)
- A declaration by a contributor about their identity and any potential conflicts of interest, sometimes required for substantial contributions to open-source projects.
- patch
- A piece of code that modifies existing software to fix bugs, add features, or improve performance.