aarch64: remove casts from more struct initializers
Cleans up struct initializers in aarch64 target code.
Jan Beulich submitted a patch to further clean up struct initializers in the aarch64 target’s code generation, specifically addressing issues in aarch64-gen.c that were missed by a previous commit. Alice Carlotti acknowledged the patch and apologized for prior breakage.
- proposer
Submitted a patch to remove unnecessary casts from struct initializers in the aarch64 code generation, extending previous cleanup efforts.
“Commit 0e89ce812b79 ("aarch64: Remove cast from struct initializer") didn't go quite far enough: The building of aarch64-gen itself has a similar issue. Cover that as well. Since FLD_CONST_* are used only there, move their #define-s there rather than introducing more #undef-s.”
- reviewer
Acknowledged the patch and apologized for previous issues caused by related changes.
“OK, thanks - and apologies again for the breakage.”
Technical Tradeoffs
- Minor code simplification versus the minimal risk of introducing regressions in opcode generation.
- Improving code clarity by removing casts.
In Details
This patch in binutils targets the aarch64 architecture's opcode generation. It refines aarch64-gen.c by removing superfluous casts in struct initializers, addressing an oversight from a prior commit (0e89ce812b79). The change also relocates FLD_CONST_* definitions to reduce boilerplate.