x86: Redundant 'x64' attributes for AMD Zen6 instructions
Removes redundant 'x64' attributes from new AMD Zen6 instructions.
Jan Beulich points out that the ‘x64’ attributes added for new AMD Zen6 instructions (RMPDIRTY, RMPOPT) are redundant because the context already implies a 64-bit architecture. He notes this is similar to the RMPREAD instruction and indicates he will provide a patch to correct this. This clean-up improves the accuracy and conciseness of the instruction definitions.
- reviewer
Identifies redundant 'x64' attributes in new AMD Zen6 instruction definitions.
“Since you have implied x64 here ... ... I believe we do not need the x64 here. They are redundant.”
- proposer
Confirms the redundancy and states intent to submit a corrective patch.
“Indeed. The same applies to RMPREAD - I'll make a patch to remove the ex”
Technical Tradeoffs
- Minor code cleanup, improving maintainability and accuracy.
- No functional change, purely a correctness improvement in the definition files.
In Details
This discussion concerns the x86 instruction definitions within binutils. Specifically, it addresses the addition of new AMD Zen6 instructions (RMPDIRTY, RMPOPT) and identifies that the 'x64' architecture attribute in their opcode table definitions is redundant, as the context implies 64-bit operation. The maintainer agrees and plans to submit a fix.
- x64
- Refers to the 64-bit extension of the x86 instruction set architecture, commonly used in modern desktop and server processors.
- AMD Zen6
- The codename for a future microarchitecture from AMD, implying new instructions or enhancements.
- opcodes table
- A data structure, often a C array, used by assemblers and disassemblers to map instruction mnemonics and their encodings.