Check allocation returns in elflink.c and optimize string concatenation
This commit adds null checks for `bfd_alloc` and `bfd_malloc` in `elflink.c` and replaces `sprintf` with `memcpy` for string concatenation, enhancing robustnes…
The Binutils BFD library’s elflink.c file, responsible for ELF linking, has been made more robust by adding checks for non-null returns from memory allocation functions (bfd_alloc and bfd_malloc). Previously, a failed allocation could lead to undefined behavior or crashes. Additionally, a less efficient sprintf call for concatenating strings in get_dynamic_reloc_section_name has been replaced with faster memcpy operations, improving performance and reliability.
In Details
In the Binutils BFD library, elflink.c handles ELF-specific linking logic. This commit introduces critical null checks for bfd_malloc in bfd_elf_link_record_dynamic_symbol and bfd_alloc in get_dynamic_reloc_section_name. Unchecked allocation failures could lead to crashes in low-memory conditions or with malformed inputs. Furthermore, get_dynamic_reloc_section_name now uses memcpy for concatenating relocation section names, eliminating the overhead of sprintf and its implicit null-termination behavior, which is more efficient for known string lengths and removes a redundant nu…
For Context
Binutils provides tools for working with compiled programs, including a library called BFD that handles different executable file formats, like ELF (Executable and Linkable Format), which is common on Linux. This commit improves the reliability and efficiency of Binutils, especially when linking ELF files. First, it adds safety checks to ensure that when the program asks for memory to store data, it actually gets that memory. If memory isn't available, the program will now fail gracefully instead of crashing. Second, it optimizes how some text strings are put together by replacing a general-purpose function (sprintf) with more direct and faster methods (memcpy), making the linking process slightly more efficient.