Removes Obsolete Return Handling Code
Removes code related to temporary aggregate returns, which are no longer created by the Ada compiler.
This commit removes an obsolete trick in Analyze_Function_Return within the Ada compiler. The compiler no longer creates a temporary variable for controlled aggregate return values, which makes the existing code unnecessary. Removing the code simplifies the compiler and improves its efficiency.
In Details
In GNAT, Analyze_Function_Return in sem_ch6.adb analyzes function return statements. This commit removes code that wrapped aggregate returns in a block, as this is no longer needed. A toolchain developer outside the Ada front-end might view this as a cleanup of outdated code.
For Context
This commit cleans up some unnecessary code in the Ada compiler. The code was originally designed to handle a specific situation related to how functions return complex data structures. However, the compiler has been updated, and this situation no longer occurs, so the code is no longer needed. Removing it makes the compiler simpler and slightly more efficient.